0xMiden / 0xMiden/rust-sdk

Rename `mint` CLI command

Ouverte
#1,599 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
cli
Langage dominant
Rust
Étoiles
78
Forks
129
Merge moyen
4 j 14 h
PR mergées (30 j)
52

Description

### Background

A new `mint` command will be implemented in the `miden-faucet` repository and exposed through `midenup`, allowing users to run `miden mint` (which maps to the underlying `miden-faucet mint` command). See this issue here for more information: https://github.com/0xMiden/miden-faucet/issues/192

However, the `miden-client` repository already contains a `mint` command used to mint assets from a locally tracked (and created) faucet account.

### Problem

For users interacting with components like `miden-client` and `miden-faucet` through `midenup` (which most users will do in the future), having two commands with identical names creates confusion:
1. The distinction between their functionalities is not immediately apparent
2. This presents a potential future naming collision

### Proposed Solution

Rename the `miden-client mint` command to something more specific, such as `mint-local` (which was already proposed by @igamigo in a recent PR on the `miden-client` repository), to clearly differentiate it from the `miden-faucet mint` command.

This would make it immediately clear that:
- `miden mint` => mints from the live faucet
- `miden mint-local`=> mints from a locally tracked faucet account

Any thoughts on this are highly appreciated!

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.