0xMiden / 0xMiden/rust-sdk

Rename `mint` CLI command

Aberta
#1,599 4 comentários 0 reações 0 responsáveis Ver no GitHub
cli
Linguagem predominante
Rust
Estrelas
78
Forks
129
Merge médio
4d 14h
PRs com merge (30d)
52

Descrição

### Background

A new `mint` command will be implemented in the `miden-faucet` repository and exposed through `midenup`, allowing users to run `miden mint` (which maps to the underlying `miden-faucet mint` command). See this issue here for more information: https://github.com/0xMiden/miden-faucet/issues/192

However, the `miden-client` repository already contains a `mint` command used to mint assets from a locally tracked (and created) faucet account.

### Problem

For users interacting with components like `miden-client` and `miden-faucet` through `midenup` (which most users will do in the future), having two commands with identical names creates confusion:
1. The distinction between their functionalities is not immediately apparent
2. This presents a potential future naming collision

### Proposed Solution

Rename the `miden-client mint` command to something more specific, such as `mint-local` (which was already proposed by @igamigo in a recent PR on the `miden-client` repository), to clearly differentiate it from the `miden-faucet mint` command.

This would make it immediately clear that:
- `miden mint` => mints from the live faucet
- `miden mint-local`=> mints from a locally tracked faucet account

Any thoughts on this are highly appreciated!

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.