0xMiden / 0xMiden/protocol

AggLayer: combine `faucet_registry_map` and `faucet_metadata_map`

未关闭
#2,885 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
agglayer
主要语言
Rust
星标
132
派生
167
平均合并
1 天 23 小时
30 天内合并 PR
110

描述

> Splitting into separate maps would just multiply storage slots without buying anything.
>
> Agreed! I wonder if it would make sense to push this even further and combine `faucet_registry_map` with `faucet_metadata_map`. We could use the fourth element in sub-key `1` to track the `is_native` flag).
>
> Another question (mostly to clarify my understanding): we store the metadata hash in the map - but where does the actual metadata get stored? And why do we need 8 elements for the hash? Is this because we need to hash it using Keccak for some reason?

_Originally posted by @bobbinth in [#2700](https://github.com/0xMiden/protocol/issues/2700#issuecomment-4270543362)_

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。