0xMiden / 0xMiden/protocol

AggLayer: combine `faucet_registry_map` and `faucet_metadata_map`

Ouverte
#2,885 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
agglayer
Langage dominant
Rust
Étoiles
132
Forks
167
Merge moyen
1 j 23 h
PR mergées (30 j)
110

Description

> Splitting into separate maps would just multiply storage slots without buying anything.
>
> Agreed! I wonder if it would make sense to push this even further and combine `faucet_registry_map` with `faucet_metadata_map`. We could use the fourth element in sub-key `1` to track the `is_native` flag).
>
> Another question (mostly to clarify my understanding): we store the metadata hash in the map - but where does the actual metadata get stored? And why do we need 8 elements for the hash? Is this because we need to hash it using Keccak for some reason?

_Originally posted by @bobbinth in [#2700](https://github.com/0xMiden/protocol/issues/2700#issuecomment-4270543362)_

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.