0xMiden / 0xMiden/protocol

AggLayer: combine `faucet_registry_map` and `faucet_metadata_map`

Aperta
#2,885 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
agglayer
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

> Splitting into separate maps would just multiply storage slots without buying anything.
>
> Agreed! I wonder if it would make sense to push this even further and combine `faucet_registry_map` with `faucet_metadata_map`. We could use the fourth element in sub-key `1` to track the `is_native` flag).
>
> Another question (mostly to clarify my understanding): we store the metadata hash in the map - but where does the actual metadata get stored? And why do we need 8 elements for the hash? Is this because we need to hash it using Keccak for some reason?

_Originally posted by @bobbinth in [#2700](https://github.com/0xMiden/protocol/issues/2700#issuecomment-4270543362)_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.