0xMiden / 0xMiden/protocol

AggLayer: combine `faucet_registry_map` and `faucet_metadata_map`

Open
#2,885 1 comment 0 reactions 0 assignees View on GitHub
agglayer
Dominant language
Rust
Stars
132
Forks
167
Avg merge
1d 23h
Merged PRs (30d)
110

Description

> Splitting into separate maps would just multiply storage slots without buying anything.
>
> Agreed! I wonder if it would make sense to push this even further and combine `faucet_registry_map` with `faucet_metadata_map`. We could use the fourth element in sub-key `1` to track the `is_native` flag).
>
> Another question (mostly to clarify my understanding): we store the metadata hash in the map - but where does the actual metadata get stored? And why do we need 8 elements for the hash? Is this because we need to hash it using Keccak for some reason?

_Originally posted by @bobbinth in [#2700](https://github.com/0xMiden/protocol/issues/2700#issuecomment-4270543362)_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.