0xMiden / 0xMiden/protocol

Normalize construction of `ProvenTransaction`, `ProvenBlock` and `ProvenBatch`

Đang mở
#1,297 0 bình luận 2 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Rust
Star
132
Fork
167
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
110

Mô tả

Related to https://github.com/0xPolygonMiden/miden-base/issues/1150

We need to standardize a method to verify the internal consistency of the `Proven{Batch, Block, Transaction}` structs at the moment of initialization/deserialization. Only `ProvenTransaction` currently supports full internal consistency verification after ZKP verification.

We need to determine what (if any) consistency checks should happen during deserialization.

In @bobbinth words (https://github.com/0xPolygonMiden/miden-base/issues/1150#issuecomment-2800081181):
Basically, with ProvenX structs, we should be able to ensure that the struct is fully internally consistent after verifying the attached ZKP (currently, this is possible only for the ProvenTransaction). This is probably not something we should do on deserialization - but we should align on what guarantees we uphold on deserialization (if any) and have a consistent way for verifying internal consistency of the structs.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.