0xMiden / 0xMiden/protocol

Normalize construction of `ProvenTransaction`, `ProvenBlock` and `ProvenBatch`

Ouverte
#1,297 0 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
132
Forks
167
Merge moyen
1 j 23 h
PR mergées (30 j)
110

Description

Related to https://github.com/0xPolygonMiden/miden-base/issues/1150

We need to standardize a method to verify the internal consistency of the `Proven{Batch, Block, Transaction}` structs at the moment of initialization/deserialization. Only `ProvenTransaction` currently supports full internal consistency verification after ZKP verification.

We need to determine what (if any) consistency checks should happen during deserialization.

In @bobbinth words (https://github.com/0xPolygonMiden/miden-base/issues/1150#issuecomment-2800081181):
Basically, with ProvenX structs, we should be able to ensure that the struct is fully internally consistent after verifying the attached ZKP (currently, this is possible only for the ProvenTransaction). This is probably not something we should do on deserialization - but we should align on what guarantees we uphold on deserialization (if any) and have a consistent way for verifying internal consistency of the structs.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.