0xMiden / 0xMiden/protocol

Normalize construction of `ProvenTransaction`, `ProvenBlock` and `ProvenBatch`

Aperta
#1,297 0 commenti 2 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

Related to https://github.com/0xPolygonMiden/miden-base/issues/1150

We need to standardize a method to verify the internal consistency of the `Proven{Batch, Block, Transaction}` structs at the moment of initialization/deserialization. Only `ProvenTransaction` currently supports full internal consistency verification after ZKP verification.

We need to determine what (if any) consistency checks should happen during deserialization.

In @bobbinth words (https://github.com/0xPolygonMiden/miden-base/issues/1150#issuecomment-2800081181):
Basically, with ProvenX structs, we should be able to ensure that the struct is fully internally consistent after verifying the attached ZKP (currently, this is possible only for the ProvenTransaction). This is probably not something we should do on deserialization - but we should align on what guarantees we uphold on deserialization (if any) and have a consistent way for verifying internal consistency of the structs.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.