0xMiden / 0xMiden/protocol

Normalize construction of `ProvenTransaction`, `ProvenBlock` and `ProvenBatch`

未關閉
#1,297 0 則留言 2 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

Related to https://github.com/0xPolygonMiden/miden-base/issues/1150

We need to standardize a method to verify the internal consistency of the `Proven{Batch, Block, Transaction}` structs at the moment of initialization/deserialization. Only `ProvenTransaction` currently supports full internal consistency verification after ZKP verification.

We need to determine what (if any) consistency checks should happen during deserialization.

In @bobbinth words (https://github.com/0xPolygonMiden/miden-base/issues/1150#issuecomment-2800081181):
Basically, with ProvenX structs, we should be able to ensure that the struct is fully internally consistent after verifying the attached ZKP (currently, this is possible only for the ProvenTransaction). This is probably not something we should do on deserialization - but we should align on what guarantees we uphold on deserialization (if any) and have a consistent way for verifying internal consistency of the structs.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。