0xMiden / 0xMiden/note-transport-service

Proto package lacks a version suffix; no buf breaking check in CI

未關閉
#135 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement production-readiness
主要語言
Rust
星號
3
分支
10
平均合併
2 小時 23 分鐘
30 天內合併 PR
4

描述

Severity: medium.

### Summary

The proto package is `miden_note_transport` with no `.v1` suffix (`proto/proto/miden_note_transport.proto:3`) and there is no `buf breaking` check in CI. Reflection (v1) is registered.

### Impact

For a production internet-facing API there is no path to introduce v2 side-by-side, and nothing guards against accidental wire-breaking edits (field renumbering, etc.).

### Recommendation

Rename to `miden.note_transport.v1` before GA (breaking now is cheap, later impossible) and add `buf breaking` to CI.

---
Part of #114.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。