0xMiden / 0xMiden/note-transport-service

Proto package lacks a version suffix; no buf breaking check in CI

未关闭
#135 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement production-readiness
主要语言
Rust
星标
3
派生
10
平均合并
2 小时 23 分钟
30 天内合并 PR
4

描述

Severity: medium.

### Summary

The proto package is `miden_note_transport` with no `.v1` suffix (`proto/proto/miden_note_transport.proto:3`) and there is no `buf breaking` check in CI. Reflection (v1) is registered.

### Impact

For a production internet-facing API there is no path to introduce v2 side-by-side, and nothing guards against accidental wire-breaking edits (field renumbering, etc.).

### Recommendation

Rename to `miden.note_transport.v1` before GA (breaking now is cheap, later impossible) and add `buf breaking` to CI.

---
Part of #114.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。