0xMiden / 0xMiden/note-transport-service
Proto package lacks a version suffix; no buf breaking check in CI
Offen
enhancement
production-readiness
- Vorherrschende Sprache
- Rust
- Sterne
- 3
- Forks
- 10
- Ø Merge
- 2 Std. 23 Min.
- Gemergte PRs (30 T.)
- 4
Beschreibung
Severity: medium.
### Summary
The proto package is `miden_note_transport` with no `.v1` suffix (`proto/proto/miden_note_transport.proto:3`) and there is no `buf breaking` check in CI. Reflection (v1) is registered.
### Impact
For a production internet-facing API there is no path to introduce v2 side-by-side, and nothing guards against accidental wire-breaking edits (field renumbering, etc.).
### Recommendation
Rename to `miden.note_transport.v1` before GA (breaking now is cheap, later impossible) and add `buf breaking` to CI.
---
Part of #114.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.