0xMiden / 0xMiden/miden-vm

Computing the norm of Falcon signature polynomial $s_2$

Đang mở
#1,672 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
corelib
Ngôn ngữ chính
Rust
Star
772
Fork
352
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
93

Mô tả

When computing the square norm of the signature polynomial $s_2$ we are doing some `u32` comparisons in order to compute the square of the centered values using `norm_sq`.
On the other hand, during the probabilistic product check, we are also range checking the coefficients of $s_2$ to be less than Falcon prime.
It seems like there is some redundant checks on these coefficients and it would be nice to find a way to optimize them.
I have now added bound checks on the coefficients of `s2` similar to those on `h`.
This has unfortunately led to an increase in the number of cycles, the current cycle count is just shy of 60000 cycles. We can comeback to this to see if we can optimize these checks.

_Originally posted by @Al-Kindi-0 in https://github.com/0xPolygonMiden/miden-vm/pull/1661#discussion_r1967664373_

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.