0xMiden / 0xMiden/miden-vm

Computing the norm of Falcon signature polynomial $s_2$

Offen
#1,672 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
corelib
Vorherrschende Sprache
Rust
Sterne
772
Forks
352
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
93

Beschreibung

When computing the square norm of the signature polynomial $s_2$ we are doing some `u32` comparisons in order to compute the square of the centered values using `norm_sq`.
On the other hand, during the probabilistic product check, we are also range checking the coefficients of $s_2$ to be less than Falcon prime.
It seems like there is some redundant checks on these coefficients and it would be nice to find a way to optimize them.
I have now added bound checks on the coefficients of `s2` similar to those on `h`.
This has unfortunately led to an increase in the number of cycles, the current cycle count is just shy of 60000 cycles. We can comeback to this to see if we can optimize these checks.

_Originally posted by @Al-Kindi-0 in https://github.com/0xPolygonMiden/miden-vm/pull/1661#discussion_r1967664373_

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.