0xMiden / 0xMiden/miden-vm

Computing the norm of Falcon signature polynomial $s_2$

Abierto
#1,672 0 comentarios 0 reacciones 0 asignados Ver en GitHub
corelib
Lenguaje dominante
Rust
Estrellas
772
Forks
352
Merge medio
1 d 12 h
PR fusionados (30 d)
93

Descripción

When computing the square norm of the signature polynomial $s_2$ we are doing some `u32` comparisons in order to compute the square of the centered values using `norm_sq`.
On the other hand, during the probabilistic product check, we are also range checking the coefficients of $s_2$ to be less than Falcon prime.
It seems like there is some redundant checks on these coefficients and it would be nice to find a way to optimize them.
I have now added bound checks on the coefficients of `s2` similar to those on `h`.
This has unfortunately led to an increase in the number of cycles, the current cycle count is just shy of 60000 cycles. We can comeback to this to see if we can optimize these checks.

_Originally posted by @Al-Kindi-0 in https://github.com/0xPolygonMiden/miden-vm/pull/1661#discussion_r1967664373_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.