HTTP server: Persistent connection on HTTP/1.0 hangs, when using streaming response body
还没有人认领这个 Issue。
评估
调研方向
Start at src/Io/StreamingServer.php around line 308 and reproduce the issue with the provided streaming ThroughStream example and curl --http1.0 request. Trace how an HTTP/1.0 response with an unknown body size handles Connection: keep-alive; done means the response is transmitted and the connection closes instead of hanging.
由索引模型根据 Issue 内容生成。
描述
Assuming the response body is streaming and its size is unknown, when a request such as this is received:
GET / HTTP/1.0
Connection: keep-alive
ReactPHP produces a response without a Content-Length header, such as this:
HTTP/1.0 200 OK
Connection: keep-alive
<data>
and doesn't close the connection, which then just hangs until timeout, because for the client there is no way of telling, when the response data is finished transmitting.
Steps to reproduce:
$server = new React\Http\HttpServer(function () {
$stream = new ThroughStream();
Loop::futureTick(function () use ($stream) {
$stream->write("foo\n");
$stream->end();
});
return new Response(200, body: $stream);
});
$socket = new React\Socket\SocketServer("0.0.0.0:80");
$server->listen($socket);
curl -v --http1.0 -H "connection: keep-alive" localhost:80
Tested on v1.11.0 and 3.x-dev (4e1b4f369eea9428ac38b8851e113ce5ad47cbee).
Since it's HTTP/1.0, Transfer-Encoding: chunked cannot be used. I believe the only good way to handle this situation is to ignore the requested Connection: keep-alive and just close the connection after the response is transmitted. I think this should be a valid behavior - server is not required to strictly obey the keep-alive request header.
The relevant code is here: https://github.com/reactphp/http/blob/1.x/src/Io/StreamingServer.php#L308
- 主要语言
- PHP
- 星标
- 781
- 派生
- 166
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
reactphp/http 的其他 Issue
-
bug
难度 3/5 1-2 天 新手友好度 35/100
-
maintenance
难度 5/5 一周以上 新手友好度 20/100
-
new feature
难度 4/5 3-5 天 新手友好度 48/100
-
help wanted new feature
难度 5/5 一周以上 新手友好度 25/100
-
new feature
难度 4/5 3-5 天 新手友好度 35/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
getgrav/grav-plugin-api#45 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
RSS-Bridge/rss-bridge#5098 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
phingofficial/phing#2025 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
silverstripe/developer-docs#911 ·
-
难度 2/5 1-3 小时 新手友好度 74/100