HTTP server: Persistent connection on HTTP/1.0 hangs, when using streaming response body
還沒有人認領這個 Issue。
評估
研究方向
Start at src/Io/StreamingServer.php around line 308 and reproduce the issue with the provided streaming ThroughStream example and curl --http1.0 request. Trace how an HTTP/1.0 response with an unknown body size handles Connection: keep-alive; done means the response is transmitted and the connection closes instead of hanging.
由索引模型根據 Issue 內容生成。
描述
Assuming the response body is streaming and its size is unknown, when a request such as this is received:
GET / HTTP/1.0
Connection: keep-alive
ReactPHP produces a response without a Content-Length header, such as this:
HTTP/1.0 200 OK
Connection: keep-alive
<data>
and doesn't close the connection, which then just hangs until timeout, because for the client there is no way of telling, when the response data is finished transmitting.
Steps to reproduce:
$server = new React\Http\HttpServer(function () {
$stream = new ThroughStream();
Loop::futureTick(function () use ($stream) {
$stream->write("foo\n");
$stream->end();
});
return new Response(200, body: $stream);
});
$socket = new React\Socket\SocketServer("0.0.0.0:80");
$server->listen($socket);
curl -v --http1.0 -H "connection: keep-alive" localhost:80
Tested on v1.11.0 and 3.x-dev (4e1b4f369eea9428ac38b8851e113ce5ad47cbee).
Since it's HTTP/1.0, Transfer-Encoding: chunked cannot be used. I believe the only good way to handle this situation is to ignore the requested Connection: keep-alive and just close the connection after the response is transmitted. I think this should be a valid behavior - server is not required to strictly obey the keep-alive request header.
The relevant code is here: https://github.com/reactphp/http/blob/1.x/src/Io/StreamingServer.php#L308
- 主要語言
- PHP
- 星號
- 781
- 分支
- 166
- PR 合併指標
- 30 天內沒有已合併 PR
貢獻指南
這個儲存庫沒有索引到貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
reactphp/http 的其他 Issue
-
bug
難度 3/5 1-2 天 新手友好度 35/100
-
maintenance
難度 5/5 一週以上 新手友好度 20/100
-
new feature
難度 4/5 3-5 天 新手友好度 48/100
-
help wanted new feature
難度 5/5 一週以上 新手友好度 25/100
-
new feature
難度 4/5 3-5 天 新手友好度 35/100
相似的 Issue
-
sync-en
難度 1/5 1-3 小時 新手友好度 85/100
-
sync-en
難度 1/5 1-3 小時 新手友好度 85/100
-
Перевод устарел
難度 1/5 1-3 小時 新手友好度 78/100
-
難度 1/5 1 小時以內 新手友好度 90/100
-
難度 2/5 1-3 小時 新手友好度 85/100