Lib/types.py nit: isinstance != PyType_IsSubtype

未关闭

#67,157 创建于 2014年11月29日 7 条评论 0 个 reaction 已指派 0 人在 GitHub 查看

还没有人认领这个 Issue。

评估

难度: 4/5
预计耗时: 3-5 天
新手友好度: 25/100

Issue 类型: 缺陷
描述清晰度: 需要澄清
活跃度: 停滞
技术栈: python
领域: backend

调研方向

Start by reading Lib/types.py and the linked fix_types_calculate_meta patch files, then inspect the referenced virtual-metaclass test patches. Compare the Python implementation with the native type machinery; done means the behavior matches PyType_IsSubtype and the corresponding tests pass.

由索引模型根据 Issue 内容生成。

描述

stdlib type-bug

BPO	22968
Nosy	@1st1
Files	fix_types_calculate_meta.patch: More correct implementation of types._caclculate_meta fix_types_calculate_meta_v2.patch: v2: More correct implementation of class creation APIs in Lib/types.py fix_types_calculate_meta_v3.patch: v3: Just adds a commit message test_virtual_metaclasses.patch: Tests verifying that type machinery really works this way test_virtual_metaclasses_in_types_module.patch: Tests verifying that types.py matches type machinery test_virtual_metaclasses_in_types_module_v2.patch: Tests verifying that types.py implementation matches native type machinery

BPO

22968

Nosy

@1st1

Files

fix_types_calculate_meta.patch: More correct implementation of types._caclculate_meta

fix_types_calculate_meta_v2.patch: v2: More correct implementation of class creation APIs in Lib/types.py

fix_types_calculate_meta_v3.patch: v3: Just adds a commit message

test_virtual_metaclasses.patch: Tests verifying that type machinery really works this way

test_virtual_metaclasses_in_types_module.patch: Tests verifying that types.py matches type machinery

test_virtual_metaclasses_in_types_module_v2.patch: Tests verifying that types.py implementation matches native type machinery

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2014-11-29.20:38:33.991>
labels = ['type-bug', 'library']
title = 'Lib/types.py nit: isinstance != PyType_IsSubtype'
updated_at = <Date 2015-10-24.15:02:13.263>
user = 'https://bugs.python.org/gmt'

bugs.python.org fields:

activity = <Date 2015-10-24.15:02:13.263>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-11-29.20:38:33.991>
creator = 'gmt'
dependencies = []
files = ['37318', '37348', '37349', '37350', '37352', '37356']
hgrepos = []
issue_num = 22968
keywords = ['patch']
message_count = 7.0
messages = ['231871', '231980', '232067', '232074', '232075', '232077', '232104']
nosy_count = 2.0
nosy_names = ['yselivanov', 'gmt']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22968'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']

主要语言: Python
星标: 77.2k
派生: 36k
平均合并: 1 天 9 小时
30 天内合并 PR: 558