Lib/types.py nit: isinstance != PyType_IsSubtype

Ouverte
#67,157 7 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
25/100
Type d'issue
Bug
Clarté
À clarifier
Activité
À l'abandon
Stack technique
python
Domaine
backend

Piste de recherche

Start by reading Lib/types.py and the linked fix_types_calculate_meta patch files, then inspect the referenced virtual-metaclass test patches. Compare the Python implementation with the native type machinery; done means the behavior matches PyType_IsSubtype and the corresponding tests pass.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

stdlib type-bug
BPO 22968
Nosy @1st1
Files
  • fix_types_calculate_meta.patch: More correct implementation of types._caclculate_meta
  • fix_types_calculate_meta_v2.patch: v2: More correct implementation of class creation APIs in Lib/types.py
  • fix_types_calculate_meta_v3.patch: v3: Just adds a commit message
  • test_virtual_metaclasses.patch: Tests verifying that type machinery really works this way
  • test_virtual_metaclasses_in_types_module.patch: Tests verifying that types.py matches type machinery
  • test_virtual_metaclasses_in_types_module_v2.patch: Tests verifying that types.py implementation matches native type machinery
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-11-29.20:38:33.991>
labels = ['type-bug', 'library']
title = 'Lib/types.py nit: isinstance != PyType_IsSubtype'
updated_at = <Date 2015-10-24.15:02:13.263>
user = 'https://bugs.python.org/gmt'

    bugs.python.org fields:

    activity = <Date 2015-10-24.15:02:13.263>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-11-29.20:38:33.991>
creator = 'gmt'
dependencies = []
files = ['37318', '37348', '37349', '37350', '37352', '37356']
hgrepos = []
issue_num = 22968
keywords = ['patch']
message_count = 7.0
messages = ['231871', '231980', '232067', '232074', '232075', '232077', '232104']
nosy_count = 2.0
nosy_names = ['yselivanov', 'gmt']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22968'
versions = ['Python 3.4', 'Python 3.5', 'Python 3.6']

    Langage dominant
    Python
    Étoiles
    77.2k
    Forks
    36k
    Merge moyen
    1 j 9 h
    PR mergées (30 j)
    558

    Guide de contribution

    Ouvrir le guide de contribution

    Par où commencer

    1. Lisez l'issue en entier, puis le guide de contribution du projet.
    2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
    3. Forkez le dépôt et travaillez sur une branche.
    4. Ouvrez une pull request qui référence le numéro de l'issue.

    Autres issues de python/cpython

    Toutes les issues de python/cpython

    Issues similaires

    Plus d'issues Python

    Recevez les nouvelles issues par e-mail

    Un résumé court des issues GitHub adaptées aux débutants.