Undo/Cancel Completion Key Handler
还没有人认领这个 Issue。
评估
调研方向
The issue points to Completion.cs and the TabCompleteNext call path; start by reading that entry point alongside CompleteImpl and the vi completion entry points mentioned. Done means Ctrl+e restores the original line and cursor after repeated forward or backward completion in the supported vi modes, while leaving ordinary editing unaffected.
由索引模型根据 Issue 内容生成。
描述
Prerequisites
- Write a descriptive title.
Description of the new feature/enhancement
Like vim, it would be nice to be able to ctrl+e to cancel all the previous completions. If one gets three tabs into a completion cycle, it can be annoying to have to realize your search space is too wide and have to undo many times to get back to the initial text to be completed.
Proposed technical implementation details (optional)
Playing with the below naive implementation. Problems are tracking the "is completing" state and movement of the cursor during completions.
& {
$psrlTabState = [PSCustomObject]@{
OriginalLine = $null
OriginalCursor = 0
CompletedLine = $null
CompletedCursor = 0
}
$tabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::TabCompleteNext($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$viTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::ViTabCompleteNext($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$prevTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::TabCompletePrevious($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$viPrevTabHandlerSb = {
param($key, $arg)
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -eq $psrlTabState.CompletedLine -or
$line -cne $psrlTabState.CompletedLine -or
$cursor -ne $psrlTabState.CompletedCursor
)
{
$psrlTabState.OriginalLine = $line
$psrlTabState.OriginalCursor = $cursor
}
[Microsoft.PowerShell.PSConsoleReadLine]::ViTabCompletePrevious($key, $arg)
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
$psrlTabState.CompletedLine = $line
$psrlTabState.CompletedCursor = $cursor
}.GetNewClosure()
$cancelCompHandlerSb = {
$line = $null
$cursor = 0
[Microsoft.PowerShell.PSConsoleReadLine]::GetBufferState(
[ref]$line,
[ref]$cursor
)
if (
$null -ne $psrlTabState.CompletedLine -and
$line -ceq $psrlTabState.CompletedLine -and
$cursor -eq $psrlTabState.CompletedCursor
)
{
[Microsoft.PowerShell.PSConsoleReadLine]::Replace(
0,
$line.Length,
$psrlTabState.OriginalLine
)
[Microsoft.PowerShell.PSConsoleReadLine]::SetCursorPosition(
$psrlTabState.OriginalCursor
)
}
$psrlTabState.OriginalLine = $null
$psrlTabState.OriginalCursor = 0
$psrlTabState.CompletedLine = $null
$psrlTabState.CompletedCursor = 0
}.GetNewClosure()
Set-PSReadLineKeyHandler -Chord 'Tab' -ViMode 'Insert' -ScriptBlock $viTabHandlerSb -BriefDescription 'ViTabCompleteNextSaveState' -Description 'Match ViTabCompleteNext functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Tab' -ViMode 'Command' -ScriptBlock $tabHandlerSb -BriefDescription 'TabCompleteNextSaveState' -Description 'Match TabCompleteNext functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Shift+Tab' -ViMode 'Insert' -ScriptBlock $viPrevTabHandlerSb -BriefDescription 'ViTabCompletePreviousSaveState' -Description 'Match ViTabCompletePrevious functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Shift+Tab' -ViMode 'Command' -ScriptBlock $prevTabHandlerSb -BriefDescription 'TabCompletePreviousSaveState' -Description 'Match TabCompletePrevious functionality and save state for CancelCompletion'
Set-PSReadLineKeyHandler -Chord 'Ctrl+e' -ViMode 'Insert' -ScriptBlock $cancelCompHandlerSb -BriefDescription 'CancelCompletion' -Description 'Revert and undo all of the previous completions. Relies on SaveState suffixed key handlers.'
}
EDIT 1 : Better code implementation handling vi mode. Apparently TabCompleteNext doesn't handle VI mode like Complete or MenuComplete.
EDIT 2: Curious why TabCompleteNext doesn't have the same call stack and call CompleteImpl.
EDIT 3: Updated the script with finalized version which properly takes in account the Vi related tab complete next. I'm using chezmoi template on [scriptblock] and they are all the same accept for the *TabComplete* method they call. Now maybe there is some way to handle it with the ConsoleKeyInfo passed in to reduce the duplication. I just solved with an embedded golang template.
- 主要语言
- C#
- 星标
- 4.4k
- 派生
- 341
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
PowerShell/PSReadLine 的其他 Issue
-
Needs-Triage :mag:
难度 2/5 1-3 小时 新手友好度 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
难度 2/5 1-3 小时 新手友好度 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
难度 2/5 1-3 小时 新手友好度 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
难度 2/5 1-3 小时 新手友好度 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
难度 1/5 1 小时以内 新手友好度 68/100
PowerShell/PSReadLine#3470 · 3 个 reaction ·
查看 PowerShell/PSReadLine 的全部 Issue
相似的 Issue
-
bug
难度 1/5 1 小时以内 新手友好度 75/100
sillsdev/languageforge-lexbox#2665 ·
-
bug documentation frontend
难度 2/5 1-3 小时 新手友好度 72/100
azurenoops/spin_agent#975 ·
-
难度 2/5 1-3 小时 新手友好度 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
难度 2/5 1-3 小时 新手友好度 92/100
dotnet/AspNetCore.Docs#37699 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
SubtitleEdit/subtitleedit#15108 · 1 条评论 ·