Add option to change timeout of 20ms of ICommandPredictor ("ICommandPredictor interface has a 20ms time out for responses from the Predictors")

未关闭
#4,029 1 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
30/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
csharp, powershell
领域
cli

调研方向

Start with src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cs at the mentioned 20ms timeout, then inspect the Set-PSReadLineOption prediction settings and determine whether configuration belongs in PSReadLine or PowerShell. Done means an agreed configuration entry point, updated documentation, and coverage for changing the predictor timeout without recompiling PowerShell.

由索引模型根据 Issue 内容生成。

描述

Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Currently:
"To ensure a responsive user experience, the ICommandPredictor interface has a 20ms time out for responses from the Predictors. Your predictor code must return results in less than 20ms to be displayed."
see
https://learn.microsoft.com/en-us/powershell/scripting/dev-cross-plat/create-cmdline-predictor?view=powershell-7.4

This seem to be source code, with hard coded timeout of 20ms, see "millisecondsTimeout: 20"

src/System.Management.Automation/engine/Subsystem/PredictionSubsystem/CommandPrediction.cs

The "problem"
I find this value too low, as some of the predictors are use take more time to calculate suggestions.
I wish this value could be configured by user (me), without need to compile PowerShell.

Proposed technical implementation details (optional)

Add option to change this value, eg by using some additional call for Set-PSReadLineOption or other.
Eg, currently the next lines are used to install a predictor.

Set-PSReadLineOption -PredictionSource HistoryAndPlugin
Import-Module .\bin\Debug\net6.0\SamplePredictor.dll

The following command can be added:
Set-PSReadLineOption -PredictionTimeout 30

Technically I'm not sure if this should be Set-PSReadLineOption, or in this repo at all,
because to install the predictor, "Set-PSReadLineOption" is used,
while the timeout code is in https://github.com/PowerShell/PowerShell/

主要语言
C#
星标
4.4k
派生
341
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。