Consider using a default editor for the `ViEditVisually` function and / or issue a warning if the `$env:VISUAL` / `$env:EDITOR` value is invalid.

未关闭
#4,004 1 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
csharp
领域
cli

调研方向

Start by tracing the ViEditVisually function and how it resolves $env:VISUAL and $env:EDITOR. Define behavior for missing or invalid values, including platform-specific default editors and synchronous Windows invocation; done means users receive feedback instead of only a beep and the chosen editor behavior is covered by relevant tests.

由索引模型根据 Issue 内容生成。

描述

Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Currently, invoking the ViEditVisually function fails with no feedback other than a beep:

Consider modifying the behavior as follows, which would not only be more user-friendly in general, but also align with the behavior of other utilities, such as bash and git:

  • Use a default editor if neither $env:VISUAL no $env:EDITOR are defined - and issue a warning if it cannot be found.

    • A possible candidate on Unix-like platform is vi (this is what git does, though on some platforms it has gedit as the compiled-in default)
    • On Windows, Notepad would do as a guaranteed-to-be-present option, though that would require invocation via Start-Process -Wait (or equivalent) to ensure synchronous execution. Note that if a given machine has Git for Windows installed, nano and vim are present (but not in $env:PATH), via $env:ProgramFiles\Git\usr\bin\nano.exe and $env:ProgramFiles\Git\usr\bin\vim.exe
  • Issue a warning if the effective $env:VISUAL / $env:EDITOR value isn't valid; ditto, should the decision be made not to implement use of a default editor and neither $env:VISUAL nor $env:EDITOR is defined.

Proposed technical implementation details (optional)

No response

主要语言
C#
星标
4.4k
派生
341
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。