Configurations for the new color/style used in metadata line and warning for the scrollable list view

未关闭
#3,584 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
技术栈
csharp
领域
cli

调研方向

Start by reading the discussion linked from the issue and the six existing comments to understand the unresolved configuration options for the metadata line and scrollable list warning. No files or tests are named, and the issue is complete only once the project has an agreed configuration design and corresponding implementation scope.

由索引模型根据 Issue 内容生成。

描述

Area-Predictors Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

This issue is to follow up on https://github.com/PowerShell/PSReadLine/pull/3583#discussion_r1109181920, the discussion about what to make configurable about the new color and styles used in the metadata line and warning for the scrollable list view.

About the new colors and styles, there are a few of them:

  • un-highlighted texts in the metadata line
    • currently, the un-highlighted text uses the default inline view color/style -- this is fixed as of today.
  • highlighted text in the metadata line
    • currently, the highlighted text uses the ListPredictionColor plus italics -- so, it partially configurable.
  • warning message
    • currently, the warning message uses the ListPredictionColor plus italics.

I'm not sure about what to expose for configuration yet. It doesn't seem needed to expose them all in my opinion. The following are my thoughts at the moment:

  1. always apply italics to the text rendered in the metadata line, and use the ListPredictionColor as the user-configurable highlighting color/style.
  2. maybe expose configuration for un-highlighted text color/style, but I'm not super sure if it's really needed.
  3. warning message will be uncommon for users to see because it will happen usually only when the terminal height is very small (<5). So, exposing a configuration for it seems overkill to me.

I don't have a clear idea what/how to make configurable about the new color/styles at the moment, so I prefer to wait and collect some feedback about this, which hopefully will give us a clearer idea.

主要语言
C#
星标
4.4k
派生
341
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。