Make the ViEditVisually function more flexible by allowing $env:VISUAL / $env:EDITOR to contain an executable name *with options*

未关闭
#3,214 0 条评论 6 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
csharp, powershell
领域
cli

调研方向

Start at ViEditVisually and trace how $env:VISUAL and $env:EDITOR are resolved. Verify the existing executable-only behavior, then cover command prefixes, quoted executable names, and arguments; done means VS Code-style values work without helper scripts while invalid configurations still beep.

由索引模型根据 Issue 内容生成。

描述

In-PR Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Currently $env:VISUAL / $env:EDITOR may only contain an executable name or path, not also options.

However, to make your favorite editor act properly with this feature - a blocking invocation that returns control to the terminal when the window is closed - options may be required.

For instance, VSCode (Visual Studio Code) requires code --new-window --wait <file> ...

Therefore, you must currently create a helper (non-PowerShell) shell script / batch file in order to incorporate the necessary option, which is a lot of ceremony.

To address that, the interpretation of $env:VISUAL / $env:EDITOR could be extended to allow specifying a command line (prefix) as follows:

Proposed technical implementation details (optional)
  • First, as currently, see if the value as a whole refers to an executable (typically via $env:PATH) and, if so, use that.

  • If not, see if the first whitespace-separated / double-quoted token refers to an executable, and use that, passing all remaining tokens through as options (arguments).

  • If not, as currently, beep to indicate that no (valid) editor is configured.

For instance, this would allow users to set $env:VISUAL as follows for VSCode:

$env:VISUAL = 'code --new-window --wait'

Note: Git, which also respects these environment variables, already supports this.

主要语言
C#
星标
4.4k
派生
341
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

PowerShell/PSReadLine 的其他 Issue

查看 PowerShell/PSReadLine 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。