bugs in LossesHelper.removeSqueezableDimensions
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 928
- Forks
- 227
- PR merge metrics
- No merged PRs in 30d
Description
We execute the following statement if either rank is statically known, but it doesn't give the desired result if the other rank is unknown.
https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L215
Also, I believe we need to specify the last axis here:
https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L217
and here:
https://github.com/tensorflow/java/blob/5532bf0af4a908ee36b6017a8745e515bb3bb544/tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java#L219
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in tensorflow-framework/src/main/java/org/tensorflow/framework/losses/impl/LossesHelper.java at the referenced lines 215, 217, and 219. Trace the rank handling and axis operations, then verify the behavior for cases where one rank is unknown. Done means the unknown-rank case produces the intended result and the operations explicitly use the last axis.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100