Framework: Move Ops parameter to call method where possible
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Java
- Estrellas
- 928
- Forks
- 227
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
I'd like to move the Ops parameters of framework classes to the call method, where possible. This is primarily for Kotlin interop, but has a few other benefits as well. It won't be possible for stateful classes (Metrics, Optimizers), but should be possible for most, as far as I can tell (Initializers, Activations, Losses). I'm going to use Losses as a standin for all 3 for my examples.
- Kotlin interop w/
@FunctionInterface. If we do this, we can then define new losses likeLoss{ tf, x -> tf.stuff(x) }or pass lambdas to methods that take losses. This is very nice for layers, where we might have something Keras-likeLayer(activation=ReLU())but want to replace it with something custom. - Re-use of objects. Currently, losses create any subsequent calls in the same scope as their first call. That means if it's called inside a sub-scope, including device ones, it ignores the scope. This is somewhat expected, but not ideal. It also causes further issues if we use
Opsfor (eager) tensor lifetime management, which has been suggested and is something I'd like to do (it's easy enough to make a long-lived copy of the initial scope, but then the tensors created in the call methods live forever, and the framework classes need to be closable). - Passing configs, like Keras. In Keras, if you have a activation or loss that requires some parameters, you can pass it to a layer like
Layer(activation=LeakyReLU(alpha=0.3)). I expect this will be common with our API, as well. Currently, this runs into the above issue w/ scoping, and prevents you from passing activations (or losses) from scopes that don't have an Ops instance available.
I'd look at having the stateful classes take Ops in call as well, and only using the constructor ops for initializing state. This works better with scoping and lifetimes as mentioned above.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza revisando las clases del framework para Initializers, Activations y Losses; después, compara las clases con estado Metrics y Optimizers. Determina qué clases pueden recibir Ops en call en lugar de durante la construcción, manteniendo Ops en el constructor únicamente cuando sea necesario para la inicialización del estado. Se considera terminado cuando las APIs aplicables admitan llamadas compatibles con Kotlin y conserven el comportamiento previsto de ámbito y ciclo de vida.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- java, kotlin
- Área
- api, backend-api-design
- Tipo de issue
- Refactorización
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 20/100