swiftwasm / swiftwasm/JavaScriptKit
BridgeJS: Remove forced capture workaround in async thunk body closures once swiftlang/swift#89715 lands
@krodak já está trabalhando nisso.
Desde 10/6/2026.
- Linguagem predominante
- Swift
- Estrelas
- 986
- Forks
- 76
- Merge médio
- 21h 11min
- PRs com merge (30d)
- 4
Descrição
Tracks removal of the workaround introduced in #760.
Context
A zero-parameter async throws(JSException) export generates a captureless _bjs_makePromise body closure, which lowers via thin_to_thick_function and miscompiles on Wasm (swiftlang/swift#89320): the thrown error is corrupted across the async unwind, trapping in Promise_reject or rejecting with a garbage value. #760 works around this at the codegen level by forcing a capture in the emitted body closure (the capture must also be read in the body, since an unread capture list entry is dropped by capture analysis and the closure stays thin):
let __bjs_capture = 0
return _bjs_makePromise(resolve: Promise_resolve_SS, reject: Promise_reject) { [__bjs_capture] () async throws(JSException) -> String in
_ = __bjs_capture
return try await ping()
}
What to do once the compiler fix ships
The proper fix is swiftlang/swift#89715 (IRGen: fix async typed throws miscompiles on Wasm). Once it is available in the oldest Swift toolchain JavaScriptKit supports:
- Remove
asyncThrowsBodyForcesCaptureand the forced-capture emission fromExportedThunkBuilderinPlugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift. - Regenerate snapshots and the AoT-committed bindings.
- Keep the
zeroArgAsyncThrowsend-to-end regression test as the guard that the reject path still works without the workaround.
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Avaliação
Esta issue ainda não foi avaliada.