swiftwasm / swiftwasm/JavaScriptKit

BridgeJS: Remove forced capture workaround in async thunk body closures once swiftlang/swift#89715 lands

Offen
#761 0 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@krodak arbeitet bereits daran.

Seit 10.6.2026.

Vorherrschende Sprache
Swift
Sterne
986
Forks
76
Ø Merge
21 Std. 11 Min.
Gemergte PRs (30 T.)
4

Beschreibung

Tracks removal of the workaround introduced in #760.

Context

A zero-parameter async throws(JSException) export generates a captureless _bjs_makePromise body closure, which lowers via thin_to_thick_function and miscompiles on Wasm (swiftlang/swift#89320): the thrown error is corrupted across the async unwind, trapping in Promise_reject or rejecting with a garbage value. #760 works around this at the codegen level by forcing a capture in the emitted body closure (the capture must also be read in the body, since an unread capture list entry is dropped by capture analysis and the closure stays thin):

let __bjs_capture = 0
return _bjs_makePromise(resolve: Promise_resolve_SS, reject: Promise_reject) { [__bjs_capture] () async throws(JSException) -> String in
    _ = __bjs_capture
    return try await ping()
}

What to do once the compiler fix ships

The proper fix is swiftlang/swift#89715 (IRGen: fix async typed throws miscompiles on Wasm). Once it is available in the oldest Swift toolchain JavaScriptKit supports:

  • Remove asyncThrowsBodyForcesCapture and the forced-capture emission from ExportedThunkBuilder in Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift.
  • Regenerate snapshots and the AoT-committed bindings.
  • Keep the zeroArgAsyncThrows end-to-end regression test as the guard that the reject path still works without the workaround.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.