Provide useful debug information when an invalid soroban settings upgrade is used

Open
#4,591 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
distributed-systems

Research direction

Locate dumpProposedSettings and the upgrade command, then trace how configUpgradeSet validation failures are reported. Check how invalid proposed settings are identified and update the error path so it identifies the invalid setting; verify both reported messages for invalid Soroban settings upgrades.

Written by the indexing model from the issue text.

Description

enhancement

At the moment, dumpProposedSettings returns the message configUpgradeSet is missing or invalid if there's an issue with the proposed settings. The upgrade command also just returns Error setting configUpgradeSet on error. We should instead mention which setting is invalid.

Dominant language
C++
Stars
3.3k
Forks
1.1k
Avg merge
3d 16h
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-core

All issues in stellar/stellar-core

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.