Make LCM generation deterministic in "network externalizes empty-tx-set on missing value" test

Open
#5,437 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
distributed-systems, testing-qa

Research direction

Start with the "network externalizes empty-tx-set on missing value" test and inspect commit 9c4f4443d41222c3c49ac77f833ac3a3f8f6ccb7 to identify the removed Ledger Close Meta generation. Run the test with --check-lcm and trace the non-seeded randomness across platforms. Done means the test is deterministic and LCM generation is re-enabled without reproducing the failure.

Written by the indexing model from the issue text.

Description

bug

There is some non-seeded randomness in the "network externalizes empty-tx-set on missing value" test that causes it to fail on some platforms with --check-lcm. We removed the Ledger Close Meta generation in 9c4f4443d41222c3c49ac77f833ac3a3f8f6ccb7 to unblock #5435. We should figure out where this nondeterminism is coming from and re-enable LCM generation in this test if possible.

Dominant language
C++
Stars
3.3k
Forks
1.1k
Avg merge
3d 16h
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-core

All issues in stellar/stellar-core

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.