add proper "update" methods to the various *Frame

Open
#280 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
distributed-systems

Research direction

Start by locating the various *Frame ledger object implementations and every direct update of numSubEntries, especially around trustline additions and removals. Trace how ledger objects are changed today, then determine the update-method boundaries and invariants that must be enforced. Done means relevant changes go through those methods and numSubEntries stays correct.

Written by the indexing model from the issue text.

Description

enhancement

Updates to ledger objects should go through "update" methods that can enforce invariants:
for example, right now "numSubEntries" is updated directly, instead, it should be updated automatically when adding/removing objects (like trustlines).

Dominant language
C++
Stars
3.3k
Forks
1.1k
Avg merge
3d 16h
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stellar/stellar-core

All issues in stellar/stellar-core

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.