stdlib-js / stdlib-js/stdlib

[RFC]: Refactor random number generation in JS benchmarks for `stats/base/dists/normal`

未关闭
#4,981 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Benchmarks difficulty: 1 Good First Issue JavaScript RFC
主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 3 小时
30 天内合并 PR
611

描述

### Description

This RFC proposes improving random number generation in JS benchmarks for [`stats/base/dists/normal`](https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/normal).

**Context**: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.

When adding support, the following tasks should be completed:

1. Move random number generation out of the benchmarking loops and initialize it before the benchmarks.

2. Ensure that the generated random values use the same range as the existing values to maintain consistency.

3. Use `uniform` and `discreteUniform` from `@stdlib/random/base/uniform` and `@stdlib/random/base/discrete-uniform` instead of `randu` expressions.
- For example, replace `( randu() * 10.0 + EPS )` with `uniform( EPS, 10.0 )`.
- Replace `ceil( randu() * 10.0 + EPS )` with `discreteUniform( 1, 10 )`.

To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both `uniform` and `discreteUniform`.

### Related Issues

#4837, #4955

### Questions

No.

### Other

Once the implementation is complete, you should be able to run the following `make` commands:

#### Build Native Add-on
```sh
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/normal/*" make install-node-addons
```

#### Run JavaScript Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark/benchmark.js"
```

#### Run JavaScript Native Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark/benchmark.native.js"
```

**Note:** If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: [#4955](https://github.com/stdlib-js/stdlib/pull/4955#issuecomment-2622578367)

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

贡献指南

打开贡献指南

调研方向

Start by inspecting the benchmark.js and benchmark.native.js files under lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark, using #4837 and #4955 as implementation references. Run the listed benchmark make commands after updating the benchmark inputs; done means random values are initialized outside loops, preserve existing ranges, and both JavaScript benchmark commands complete successfully.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
performance
Issue 类型
重构
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。