stdlib-js / stdlib-js/stdlib

[RFC]: Refactor random number generation in JS benchmarks for `stats/base/dists/normal`

Abierto
#4,981 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Benchmarks difficulty: 1 Good First Issue JavaScript RFC
Lenguaje dominante
JavaScript
Estrellas
6k
Forks
1.3k
Merge medio
1 d 3 h
PR fusionados (30 d)
611

Descripción

### Description

This RFC proposes improving random number generation in JS benchmarks for [`stats/base/dists/normal`](https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/base/dists/normal).

**Context**: At present, in the remaining packages, random number generation in JS benchmarks occurs inside the benchmarking loop. Since random number generation is an expensive operation, it should be moved out of the benchmarking loops and initialized beforehand to avoid interfering with the results.

When adding support, the following tasks should be completed:

1. Move random number generation out of the benchmarking loops and initialize it before the benchmarks.

2. Ensure that the generated random values use the same range as the existing values to maintain consistency.

3. Use `uniform` and `discreteUniform` from `@stdlib/random/base/uniform` and `@stdlib/random/base/discrete-uniform` instead of `randu` expressions.
- For example, replace `( randu() * 10.0 + EPS )` with `uniform( EPS, 10.0 )`.
- Replace `ceil( randu() * 10.0 + EPS )` with `discreteUniform( 1, 10 )`.

To provide a concrete example of what a PR implementing the desired changes should contain, see #4837 and #4955, which provide examples for using both `uniform` and `discreteUniform`.

### Related Issues

#4837, #4955

### Questions

No.

### Other

Once the implementation is complete, you should be able to run the following `make` commands:

#### Build Native Add-on
```sh
NODE_ADDONS_PATTERN="@stdlib/stats/base/dists/normal/*" make install-node-addons
```

#### Run JavaScript Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark/benchmark.js"
```

#### Run JavaScript Native Benchmarks
```sh
make benchmark-javascript-files FILES="$(pwd)/lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark/benchmark.native.js"
```

**Note:** If running benchmarks results in an error, it is likely due to the random number generators producing values where the functions are not defined. To resolve this, check the relevant benchmark files, adjust the input value ranges to ensure they remain within the domain where the functions are valid, and then rerun the benchmarks. Reference: [#4955](https://github.com/stdlib-js/stdlib/pull/4955#issuecomment-2622578367)

### Checklist

- [x] I have read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.
- [x] The issue name begins with `RFC:`.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by inspecting the benchmark.js and benchmark.native.js files under lib/node_modules/@stdlib/stats/base/dists/normal/*/benchmark, using #4837 and #4955 as implementation references. Run the listed benchmark make commands after updating the benchmark inputs; done means random values are initialized outside loops, preserve existing ranges, and both JavaScript benchmark commands complete successfully.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
performance
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.