stdlib-js / stdlib-js/stdlib

CLI wrapper swallows subcommand exit codes

未关闭
#11,293 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Bug
主要语言
JavaScript
星标
6k
派生
1.3k
平均合并
1 天 3 小时
30 天内合并 PR
611

描述

### Description

While testing the CLI wrapper (bin/cli), I noticed that it doesn’t properly return the exit status of the commands it runs.

Right now, the wrapper only listens for the error event on the spawned process, which means it only catches cases where the process fails to start (like when a command isn’t found). However, it doesn’t handle exit or close events.

Because of this, if a subcommand runs but fails (returns a non-zero exit code), the main CLI still exits with 0, indicating success.

This can be misleading and may cause issues in scripts, CI/CD pipelines, or any automation that relies on correct exit codes to detect failures.

---

### Error Details

```bash
node .\bin\cli capitalize; Write-Output "WRAPPED_EXIT:$LASTEXITCODE"
→ WRAPPED_EXIT:0

node .\node_modules\@stdlib\string\capitalize\bin\cli; Write-Output "DIRECT_EXIT:$LASTEXITCODE"
→ DIRECT_EXIT:1
```

### Related Issues

None that I could find.

### Questions

No.

### Demo

_No response_

### Reproduction

```shell
- Run a wrapped stdlib CLI subcommand with invalid input that should cause it to fail.

- Check the shell's exit code (echo $? on Linux/Mac or $LASTEXITCODE on Windows).

- Observe the discrepancy between the wrapped command and the direct module command.
```

### Expected Results

```shell
The parent CLI process should catch the child's exit status and exit with the same non-zero code.
```

### Actual Results

```shell
The parent CLI process exits with code 0.
```

### Version

develop

### Environments

Node.js

### Browser Version

N/A

### Node.js / npm Version

v22.17.1

### Platform

Windows

### Checklist

- [x] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.

贡献指南

打开贡献指南

调研方向

Start by reading bin/cli and reproduce the wrapped and direct command cases from the issue, checking the parent process exit status on the available shell. Trace how the spawned subcommand currently reports errors and exits. Done means a failing subcommand causes the wrapper to return the same non-zero status while command-not-found behavior remains covered.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, node.js
领域
cli
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
冷清
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。