stdlib-js / stdlib-js/stdlib

CLI wrapper swallows subcommand exit codes

Ouverte
#11,293 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Bug
Langage dominant
JavaScript
Étoiles
6k
Forks
1.3k
Merge moyen
1 j 3 h
PR mergées (30 j)
611

Description

### Description

While testing the CLI wrapper (bin/cli), I noticed that it doesn’t properly return the exit status of the commands it runs.

Right now, the wrapper only listens for the error event on the spawned process, which means it only catches cases where the process fails to start (like when a command isn’t found). However, it doesn’t handle exit or close events.

Because of this, if a subcommand runs but fails (returns a non-zero exit code), the main CLI still exits with 0, indicating success.

This can be misleading and may cause issues in scripts, CI/CD pipelines, or any automation that relies on correct exit codes to detect failures.

---

### Error Details

```bash
node .\bin\cli capitalize; Write-Output "WRAPPED_EXIT:$LASTEXITCODE"
→ WRAPPED_EXIT:0

node .\node_modules\@stdlib\string\capitalize\bin\cli; Write-Output "DIRECT_EXIT:$LASTEXITCODE"
→ DIRECT_EXIT:1
```

### Related Issues

None that I could find.

### Questions

No.

### Demo

_No response_

### Reproduction

```shell
- Run a wrapped stdlib CLI subcommand with invalid input that should cause it to fail.

- Check the shell's exit code (echo $? on Linux/Mac or $LASTEXITCODE on Windows).

- Observe the discrepancy between the wrapped command and the direct module command.
```

### Expected Results

```shell
The parent CLI process should catch the child's exit status and exit with the same non-zero code.
```

### Actual Results

```shell
The parent CLI process exits with code 0.
```

### Version

develop

### Environments

Node.js

### Browser Version

N/A

### Node.js / npm Version

v22.17.1

### Platform

Windows

### Checklist

- [x] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [x] Searched for existing issues and pull requests.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.