stackql / stackql/stackql-deploy-rs

init google scaffold generates incorrect networks INSERT and statecheck

Aperta Adatta ai principianti
#59 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Rust
Stelle
1
Fork
0
Merge medio
12m
PR unite (30g)
4

Descrizione

Summary

The Google scaffold generated by stackql-deploy init google contains two issues in the generated VPC resource definition:

  1. The google.compute.networks.insert statement does not use the method-specific data__ fields required for the request body.
  2. The generated statecheck compares autoCreateSubnetworks with false, which did not match the deployed resource in my validation. Comparing it with 0 worked correctly.

After correcting both, I successfully validated the complete stackql-deploy build flow against a real GCP project.

Reproduction

Generate a Google stack:

stackql-deploy init google

Then run the generated stack with a valid GCP project.

The generated network resource contains an INSERT similar to:

INSERT INTO google.compute.networks
(project, name, autoCreateSubnetworks, routingConfig)
SELECT
  '{{ project }}',
  '{{ vpc_name }}',
  false,
  '{"routingMode": "REGIONAL"}';

When executed against google.compute.networks.insert, this resulted in a GCP HTTP 400 response:

Required field 'resource' not specified

Issue 1: generated INSERT fields

For this provider method, project is the path parameter, while the request-body fields use the data__ prefix.

The working INSERT is:

INSERT INTO google.compute.networks
(project, data__name, data__autoCreateSubnetworks, data__routingConfig)
SELECT
  '{{ project }}',
  '{{ vpc_name }}',
  false,
  '{"routingMode": "REGIONAL"}';

The method contract can be inspected directly with:

DESCRIBE METHOD google.compute.networks.insert;

Provider reference:

https://google-provider.stackql.io/services/compute/networks#insert-examples

The Google provider itself is working correctly; this appears to be an issue with the generated init google scaffold for this resource.

Issue 2: generated statecheck

The generated statecheck contains:

AND autoCreateSubnetworks = false

During validation, this returned no matching row even though the VPC had autoCreateSubnetworks disabled.

Changing it to:

AND autoCreateSubnetworks = 0

matched the deployed resource correctly and allowed the statecheck to pass.

End-to-end validation

After applying both changes, the stack completed successfully through the full resource lifecycle:

exists
create
statecheck
exports
successfully deployed resource
build complete

The deployment completed successfully against a real GCP project.

Expected behavior

A project generated by:

stackql-deploy init google

should produce a working scaffold that can be built without manually correcting the generated SQL.

For the generated Compute Network resource, the scaffold should:

  • use the method-specific data__ fields required by google.compute.networks.insert
  • generate a statecheck expression that correctly matches the returned autoCreateSubnetworks value

Root cause

The issue is in the generated Google scaffold for the Compute Network resource, rather than the stackql-deploy runtime or the Google provider specification.

The provider issue originally opened during diagnosis has been closed after confirming the provider method works correctly with the proper INSERT contract.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia dal punto di ingresso stackql-deploy init google e individua la definizione della risorsa Compute Network generata. Usa DESCRIBE METHOD google.compute.networks.insert per verificare i campi obbligatori del request-body, quindi confronta l’INSERT e lo statecheck generati con le forme funzionanti presenti nell’issue. Il lavoro è completato quando uno scaffold Google appena generato usa i campi data__, corrisponde correttamente a autoCreateSubnetworks e completa il build flow senza modifiche manuali.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
gcp, rust, sql
Ambito
cloud, devops
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Attiva
Chiarezza
Specificata chiaramente
Idoneità per principianti
75/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.