stackql / stackql/stackql-deploy-rs

init google scaffold generates incorrect networks INSERT and statecheck

Offen Anfängerfreundlich
#59 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Vorherrschende Sprache
Rust
Sterne
1
Forks
0
Ø Merge
12 Min.
Gemergte PRs (30 T.)
4

Beschreibung

Summary

The Google scaffold generated by stackql-deploy init google contains two issues in the generated VPC resource definition:

  1. The google.compute.networks.insert statement does not use the method-specific data__ fields required for the request body.
  2. The generated statecheck compares autoCreateSubnetworks with false, which did not match the deployed resource in my validation. Comparing it with 0 worked correctly.

After correcting both, I successfully validated the complete stackql-deploy build flow against a real GCP project.

Reproduction

Generate a Google stack:

stackql-deploy init google

Then run the generated stack with a valid GCP project.

The generated network resource contains an INSERT similar to:

INSERT INTO google.compute.networks
(project, name, autoCreateSubnetworks, routingConfig)
SELECT
  '{{ project }}',
  '{{ vpc_name }}',
  false,
  '{"routingMode": "REGIONAL"}';

When executed against google.compute.networks.insert, this resulted in a GCP HTTP 400 response:

Required field 'resource' not specified

Issue 1: generated INSERT fields

For this provider method, project is the path parameter, while the request-body fields use the data__ prefix.

The working INSERT is:

INSERT INTO google.compute.networks
(project, data__name, data__autoCreateSubnetworks, data__routingConfig)
SELECT
  '{{ project }}',
  '{{ vpc_name }}',
  false,
  '{"routingMode": "REGIONAL"}';

The method contract can be inspected directly with:

DESCRIBE METHOD google.compute.networks.insert;

Provider reference:

https://google-provider.stackql.io/services/compute/networks#insert-examples

The Google provider itself is working correctly; this appears to be an issue with the generated init google scaffold for this resource.

Issue 2: generated statecheck

The generated statecheck contains:

AND autoCreateSubnetworks = false

During validation, this returned no matching row even though the VPC had autoCreateSubnetworks disabled.

Changing it to:

AND autoCreateSubnetworks = 0

matched the deployed resource correctly and allowed the statecheck to pass.

End-to-end validation

After applying both changes, the stack completed successfully through the full resource lifecycle:

exists
create
statecheck
exports
successfully deployed resource
build complete

The deployment completed successfully against a real GCP project.

Expected behavior

A project generated by:

stackql-deploy init google

should produce a working scaffold that can be built without manually correcting the generated SQL.

For the generated Compute Network resource, the scaffold should:

  • use the method-specific data__ fields required by google.compute.networks.insert
  • generate a statecheck expression that correctly matches the returned autoCreateSubnetworks value

Root cause

The issue is in the generated Google scaffold for the Compute Network resource, rather than the stackql-deploy runtime or the Google provider specification.

The provider issue originally opened during diagnosis has been closed after confirming the provider method works correctly with the proper INSERT contract.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne beim Einstiegspunkt stackql-deploy init google und finde die generierte Definition der Compute Network-Ressource. Verwende DESCRIBE METHOD google.compute.networks.insert, um die erforderlichen Request-Body-Felder zu überprüfen, und vergleiche anschließend das generierte INSERT und statecheck mit den funktionierenden Formen im Issue. Die Aufgabe ist abgeschlossen, wenn ein frisch generiertes Google-Scaffold die data__-Felder verwendet, korrekt mit autoCreateSubnetworks übereinstimmt und den Build-Flow ohne manuelle Änderungen abschließt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
gcp, rust, sql
Bereich
cloud, devops
Issue-Typ
Bug
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
75/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.