Allow both BASIC and DIGEST at once

Open
#209 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
authentication

Research direction

Start in websocket-sharp/Net/HttpListener.cs around lines 512-515, where the current authentication choice is enforced. Trace how Basic and Digest headers are handled, then verify that a Basic header is accepted while a missing or unsuitable Basic header produces a Digest challenge. The issue does not name a test file, so identify the relevant authentication coverage before marking the behavior complete.

Written by the indexing model from the issue text.

Description

Right now the library forces us to choose one or the other (https://github.com/sta/websocket-sharp/blob/master/websocket-sharp/Net/HttpListener.cs#L512-L515). However, what if we want the option for either? Could you modify this so that it will accept an HTTP Basic header if present, but return a digest challenge if not? Or is that too case specific?

Dominant language
C#
Stars
6.1k
Forks
1.7k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sta/websocket-sharp

All issues in sta/websocket-sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.