Authentication failure
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.1k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Description
Currently if the authentication fails, you cannot see this in the OnClose or OnError callbacks.
Suggestion:
- Add 'AuthenticationFailure' to CloseStatusCode
- In WebSocket.doHandshake() if response.IsUnauthorized, close with eventcode CloseStatusCode.AuthenticationFailure
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WebSocket.doHandshake() and inspect the existing CloseStatusCode values and unauthorized-response handling. Add the requested authentication-failure status so an unauthorized handshake closes with that code, then verify the result is visible through the OnClose or OnError callbacks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100