Context takeover

Open
#110 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
networking

Research direction

Read the linked WebSocket compression description first, then reproduce the failure with websocket-sharp, Tornado, and a Unity client using a second server message. Confirm whether compression context takeover is negotiated and identify what behavior is needed for the second message to succeed; completion should include interoperability validation.

Written by the indexing model from the issue text.

Description

We recently found a problem using websoket-sharp together with Tornado as a server (python framework with websocket support). Unity client was crushing on a second message from the server. After some investigation I found websocket-sharp doesn't send no_context_takeover header option, allowing server websocket to be persistent (and to use the same sliding window and Huffman tree). Good description can be found here

The question is, is it a bug or a feature and are there some chances to have a support of persistent compression?

Dominant language
C#
Stars
6.1k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sta/websocket-sharp

All issues in sta/websocket-sharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.