sql-js / sql-js/sql.js

Incremental Blob Support

未关闭
#96 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
JavaScript
星标
13.7k
派生
1.1k
PR 合并指标
30 天内没有已合并 PR

描述

First, thanks for all the great work on this project. This isn't really an issue; I'm just hoping for a little help in something I'm trying to add. I figured this would be the easiest way to ask for the help.

I'm trying to add incremental blob support to sql.js. The problem I'm having is with the following sqlite3 function:

int sqlite3_blob_open( sqlite3_, const char *zDb, const char *zTable, const char *zColumn, v iRow, int flags, sqlite3_blob *_ppBlob ); https://www.sqlite.org/c3ref/blob_open.html

The problem I'm having is that when I pass in the rowid, I believe it is not being interpreted as 64-bit. Here is the error I get when I try to call it with a rowid of 1:

Uncaught Error: no such rowid: 4294967297

and with a rowid of 2:

Uncaught Error: no such rowid: 4294967298

I believe 4294967297 as 64 bit casted to 32 bit is 1, and the same with 4294967298 and 2, obviously. So I believe what's happening is that the emscripten compiler is making the sqlite3_int64 into a javascript Number and that is causing the problem. Perhaps this question is better posted to the emscripten project and if so let me know and I'll post it there. Anyway, does anyone know how I can get the generated JS code to accept a sqlite3_int64?

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

Start by reproducing the sqlite3_blob_open call described in the issue with rowids 1 and 2, then read the linked SQLite blob_open documentation and inspect the generated JavaScript boundary. Done means sqlite3_int64 rowids are passed without becoming 4294967297 or 4294967298, and incremental blob opening works for those values.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
database
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。