sql-js / sql-js/sql.js

Incremental Blob Support

Abierto
#96 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
JavaScript
Estrellas
13.7k
Forks
1.1k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

First, thanks for all the great work on this project. This isn't really an issue; I'm just hoping for a little help in something I'm trying to add. I figured this would be the easiest way to ask for the help.

I'm trying to add incremental blob support to sql.js. The problem I'm having is with the following sqlite3 function:

int sqlite3_blob_open( sqlite3_, const char *zDb, const char *zTable, const char *zColumn, v iRow, int flags, sqlite3_blob *_ppBlob ); https://www.sqlite.org/c3ref/blob_open.html

The problem I'm having is that when I pass in the rowid, I believe it is not being interpreted as 64-bit. Here is the error I get when I try to call it with a rowid of 1:

Uncaught Error: no such rowid: 4294967297

and with a rowid of 2:

Uncaught Error: no such rowid: 4294967298

I believe 4294967297 as 64 bit casted to 32 bit is 1, and the same with 4294967298 and 2, obviously. So I believe what's happening is that the emscripten compiler is making the sqlite3_int64 into a javascript Number and that is causing the problem. Perhaps this question is better posted to the emscripten project and if so let me know and I'll post it there. Anyway, does anyone know how I can get the generated JS code to accept a sqlite3_int64?

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Start by reproducing the sqlite3_blob_open call described in the issue with rowids 1 and 2, then read the linked SQLite blob_open documentation and inspect the generated JavaScript boundary. Done means sqlite3_int64 rowids are passed without becoming 4294967297 or 4294967298, and incremental blob opening works for those values.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
database
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.