sql-js / sql-js/sql.js

Incremental Blob Support

Open
#96 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
13.7k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

First, thanks for all the great work on this project. This isn't really an issue; I'm just hoping for a little help in something I'm trying to add. I figured this would be the easiest way to ask for the help.

I'm trying to add incremental blob support to sql.js. The problem I'm having is with the following sqlite3 function:

int sqlite3_blob_open( sqlite3_, const char *zDb, const char *zTable, const char *zColumn, v iRow, int flags, sqlite3_blob *_ppBlob ); https://www.sqlite.org/c3ref/blob_open.html

The problem I'm having is that when I pass in the rowid, I believe it is not being interpreted as 64-bit. Here is the error I get when I try to call it with a rowid of 1:

Uncaught Error: no such rowid: 4294967297

and with a rowid of 2:

Uncaught Error: no such rowid: 4294967298

I believe 4294967297 as 64 bit casted to 32 bit is 1, and the same with 4294967298 and 2, obviously. So I believe what's happening is that the emscripten compiler is making the sqlite3_int64 into a javascript Number and that is causing the problem. Perhaps this question is better posted to the emscripten project and if so let me know and I'll post it there. Anyway, does anyone know how I can get the generated JS code to accept a sqlite3_int64?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the sqlite3_blob_open call described in the issue with rowids 1 and 2, then read the linked SQLite blob_open documentation and inspect the generated JavaScript boundary. Done means sqlite3_int64 rowids are passed without becoming 4294967297 or 4294967298, and incremental blob opening works for those values.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
database
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.