slackapi / slackapi/bolt-python
Enable developers to inject non-bolt arguments to listener function args
@seratch y travaille déjà.
Depuis le 25/8/2022.
- Langage dominant
- Python
- Étoiles
- 1.3k
- Forks
- 288
- Merge moyen
- 1 j 8 h
- PR mergées (30 j)
- 10
Description
I'm using dependency_injector to provide automatic dependency injection for my application, and I'm encountering an issue with Bolt overriding injected parameters with None since it doesn't recognize them.
Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`
The slack_bolt version
slack-bolt==1.14.3
slack-sdk==3.18.1
Python runtime version
Python 3.10.6
OS info
ProductName: macOS
ProductVersion: 12.5.1
BuildVersion: 21G83
Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., setup.py))
- Have a kwarg that is populated by some mechanism other than bolt (such as another decorator), e.g.
@app.command('/ping')
@inject
async def handle_ping(ack, respond, version: str = Provide[Container.config.VERSION]):
await ack()
await respond({
"blocks": [
SectionBlock(text=MarkdownTextObject(text='Pong!')),
DividerBlock(),
ContextBlock(elements=[
MarkdownTextObject(text=f'*Host:* {platform.node()}'),
MarkdownTextObject(text=f'*Version:* {version}')
])
]
})
Expected result:
Bolt doesn't touch the version kwarg, but still injects the ack and respond kwargs.
Actual result:
version ends up being set to None and Bolt logs the following warning: version is not a valid argument.
This is caused by this line.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.