slackapi / slackapi/bolt-python

Enable developers to inject non-bolt arguments to listener function args

Offen
#709 7 Kommentare 3 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@seratch arbeitet bereits daran.

Seit 25.8.2022.

improvement
Vorherrschende Sprache
Python
Sterne
1.3k
Forks
288
Ø Merge
1 T. 8 Std.
Gemergte PRs (30 T.)
10

Beschreibung

I'm using dependency_injector to provide automatic dependency injection for my application, and I'm encountering an issue with Bolt overriding injected parameters with None since it doesn't recognize them.

Reproducible in:
pip freeze | grep slack
python --version
sw_vers && uname -v # or `ver`
The slack_bolt version
slack-bolt==1.14.3
slack-sdk==3.18.1
Python runtime version
Python 3.10.6
OS info
ProductName:    macOS
ProductVersion: 12.5.1
BuildVersion:   21G83
Darwin Kernel Version 21.6.0: Wed Aug 10 14:28:23 PDT 2022; root:xnu-8020.141.5~2/RELEASE_ARM64_T6000
Steps to reproduce:

(Share the commands to run, source code, and project settings (e.g., setup.py))

  1. Have a kwarg that is populated by some mechanism other than bolt (such as another decorator), e.g.
@app.command('/ping')
@inject
async def handle_ping(ack, respond, version: str = Provide[Container.config.VERSION]):
    await ack()
    await respond({
        "blocks": [
            SectionBlock(text=MarkdownTextObject(text='Pong!')),
            DividerBlock(),
            ContextBlock(elements=[
                MarkdownTextObject(text=f'*Host:* {platform.node()}'),
                MarkdownTextObject(text=f'*Version:* {version}')
            ])
        ]
    })
Expected result:

Bolt doesn't touch the version kwarg, but still injects the ack and respond kwargs.

Actual result:

version ends up being set to None and Bolt logs the following warning: version is not a valid argument.

This is caused by this line.

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.