simplesamlphp / simplesamlphp/simplesamlphp-module-oidc
are_multiple_claim_values_allowed controls all claims in a scope
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 50
- Forks
- 28
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Description
If I set are_multiple_claim_values_allowed to true in a custom scope eduperson, which I need for eduperson_affiliation, eduperson_principal_name also becomes a list even if it contains only one value (and is defined as single-valued).
Maybe the are_multiple_claim_values_allowed setting should live at the claim definition level instead of scope?
Or: Always send single valued claims as string and expand to list if are_multiple_claim_values_allowed is set to true at the scope level, this would be the least intrusive refactor. But the downside is that this behaviour would be unpredictable for the RP.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the are_multiple_claim_values_allowed setting is applied to claims within a scope, focusing on eduperson_affiliation and eduperson_principal_name. Compare the current behavior with the proposed claim-level and scope-level alternatives. Done means the project has an agreed, predictable rule for single-valued and multi-valued claims, covered by relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100