simplesamlphp / simplesamlphp/simplesamlphp-module-oidc
make configurable in which part of the OIDC exchange custom claims should be sent
还没有人认领这个 Issue。
- 主要语言
- PHP
- 星标
- 50
- 派生
- 28
- 平均合并
- 1 分钟
- 30 天内合并 PR
- 2
描述
In the authorization code flow, custom claims can be sent either in the "id_token" or by querying the "userinfo".
If the client made a preference as to where the claims should be by setting the "claims parameter", the module honours this and sends accordingly.
If no preference is indicated by the client, the module currently sends custom claims always via the userinfo endpoint. As per OIDC core spec, the claims /could/ alternatively be sent directly in the id_token.
The issue at hand suggests to make configurable where a specific custom claim should be sent. The suggested place is the OIDC-to-SAML attribute mapping table, as this lists every single claim
Example, for a hypothetical custom claim "foobar":
// The default translate table from SAML attributes to OIDC claims.
ModuleConfig::OPTION_AUTH_SAML_TO_OIDC_TRANSLATE_TABLE => [
...
'foobar' => [
'attribute' => 'urn:x-randomvendor:attibute-xyz',
'dest' => 'userinfo' # or 'id_token'
],
There should be a backwards-compatible default (single-string array defaults to "userinfo", to keep the current behaviour).
An open question is how to prioritise if the client did send a claim parameter, but the configured destination differs from the configured destination - which one wins?
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 OIDC-to-SAML 属性映射表开始,跟踪将 custom claims 发送到 userinfo endpoint 或 id_token 的 authorization code flow。定义映射如何支持向后兼容的 userinfo 默认值,然后确定显式的 client claims 参数应如何与已配置的目标交互。完成的标准是:每个已配置的 custom claim 都能被正确路由,同时不改变现有默认值。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- php
- 领域
- api, authentication
- Issue 类型
- 功能
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100