Windows viewer installer ignores `/D` switch (to override install directory)
@nat-goodspeed is already working on this.
Since Nov 19, 2024.
Assessment
This issue has not been assessed yet.
Description
Environment
Second Life Release 7.1.10.10800445603 (64bit)
Release Notes
CPU: AMD Ryzen Threadripper 3960X 24-Core Processor (3800.11 MHz)
Memory: 65413 MB
OS Version: Microsoft Windows 10 64-bit (Build 19045.5011)
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: NVIDIA GeForce GTX 970/PCIe/SSE2
Windows Graphics Driver Version: 32.0.15.6603
OpenGL Version: 4.6.0 NVIDIA 566.03
Window size: 2060x1562
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 128m
Bandwidth: 3000kbit/s
LOD factor: 1.25
Render quality: 2
Texture memory: 4096MB
Disk cache: Max size 1638.4 MB (9.6% used)
J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091639
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version:
November 15 2024 11:42:51
Description
Automated test scripts (e.g. secondlife/vita#1) want to be able to install the subject viewer to a temporary directory, without overwriting the test user's usual viewer. The NSIS installer accepts a /D switch, allowing a command line invocation to specify the default install directory. This has worked in the past.
The current Windows installer_template.nsi logic changed so that the resulting installer's /D switch is ignored.
Reproduction steps
- Download any recent viewer installer.
- Open Command Prompt.
- Type
"full\pathname\of\installer.exe" /D=desired\install\directory
(note: no quotes arounddesired\install\directory) - Expected: The default install directory will be
desired\install\directory - Actual: The default install directory is
C:\Program Files\<channel>
e.g.C:\Program Files\SecondLifeViewer
- Dominant language
- C++
- Stars
- 299
- Forks
- 146
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 88
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from secondlife/viewer
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
secondlife/viewer#6293 · 2 comments ·
-
enhancement stale
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
secondlife/viewer#5969 · 4 comments ·
-
enhancement stale
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
secondlife/viewer#5875 ·
-
bug triage
Difficulty 3/5 1-2 days Newbie friendliness 65/100
secondlife/viewer#6348 ·
-
bug triage
Difficulty 4/5 3-5 days Newbie friendliness 55/100
secondlife/viewer#6345 ·
All issues in secondlife/viewer
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·