The Cancel button in Advanced Graphics Preferences reverts all graphics settings according to the previous mode and not the changes made

Open
#2,791 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
computer-graphics, desktop

Research direction

Start at the Preferences - Graphics entry point and reproduce the Low-to-Ultra quality sequence using Advanced Settings and Cancel. Trace how the dialog saves and restores graphics settings, then verify that Cancel only undoes edits made during the current dialog session and preserves the selected quality mode.

Written by the indexing model from the issue text.

Description

bug stale triage
Environment
Environment

Second Life Release 7.1.11.11074622243 (64bit)
Release Notes

You are at 118.4, 109.9, 23.2 in Bug Island 2 located at simhost-0ad04c4bcce5e167c.agni
SLURL: http://maps.secondlife.com/secondlife/Bug%20Island%202/118/110/23
(global coordinates 260470.0, 249454.0, 23.2)
Second Life Server 2024-09-13.10853867644
Release Notes

CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (2600 MHz)
Memory: 16384 MB
OS Version: macOS 14.5.0 Darwin 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:09:52 PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
Graphics Card Vendor: ATI Technologies Inc.
Graphics Card: AMD Radeon Pro 555X OpenGL Engine

OpenGL Version: 4.1 ATI-5.5.17

Window size: 1284x1056
Font Size Adjustment: 96pt
UI Scaling: 1
Draw distance: 64m
Bandwidth: 3000kbit/s
LOD factor: 1.125
Render quality: 6
Texture memory: 4096MB
Disk cache: Max size 1638.4 MB (54.7% used)
HiDPI display mode:

J2C Decoder Version: KDU v7.10.4
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091638
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 17/9282 (0.2%)
October 04 2024 02:32:55

Reproduction steps
  1. Log in to the current release Viewer (7.1.10.10800445603).
  2. Open the Graphics preferences (Preferences - Graphics).
  3. Select the Low quality.
  4. Click on the ‘Advanced Settings…’ button.
  5. Observe the minimal settings and click the ‘Ok’ button.
  6. Select the Ultra quality.
  7. Click on the ‘Advanced Settings…’ button.
  8. Observe the maximal settings and click the ‘Cancel’ button.
  9. Click on the ‘Advanced Settings…’ button again.

Actual result:
The Cancel button in Advanced Graphics Preferences reverts all graphics settings according to the previous mode and not the changes made.
In the specified repro scenario, the user is shown Ultra mode with minimal graphics settings.

Expected result:
The Cancel button in Advanced Graphics Preferences should not revert the graphic settings to the previous mode. The Cancel button should only undo the changes made during editing.

Additional information:
This issue was found during Ad hoc testing in the scope of IQA #353.
This issue is reproduced on Win10, Win11, and OSX.

This issue is reproduced on the tested 7.1.11.11074622243 and the current release 7.1.10.10800445603 builds.

This behavior is most likely due to the ticket fix (https://github.com/secondlife/jira-archive-internal/issues/71096).

See the attached video:

  1. Actual - 7.1.11.11074622243

https://github.com/user-attachments/assets/fcb5a1a2-4887-4763-867d-5143973ba7ee

Dominant language
C++
Stars
299
Forks
146
Avg merge
1d 9h
Merged PRs (30d)
88

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from secondlife/viewer

All issues in secondlife/viewer

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.